-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated EuiForm examples #4734
Updated EuiForm examples #4734
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
@myasonik @cchaos @thompsongl Could you please review!? |
Btw, I am about to finish making the code snippet extension for Eui components! Do you think it's a good idea!? If yes I can make a PR for the same tomorrow |
Oh! What is that? |
@cchaos An extension that is similar to react code snippets where if you just type in say for example !euiAccordian, it will autofill a minimal code (the code present in snippet section of the component). Using this will help the developers as they wont have to visit the docs frequently when they want to use a component! I think it will surely help to speed up the developers while using the eui components |
Oh interesting! Without bogging down this specific PR, I've transferred your comment to a "Show and tell" type of discussion. #4735 Where we'd love to see some more of it in action if you can. |
Before I run CI on this PR, can you clean up the changed files. It looks like there are some bad test updates and the changelog is from a different PR. This one won't need a changelog because it should only address docs. |
@cchaos Sure! I am on it |
@cchaos Please view! |
@cchaos I have also uploaded a small basic screencast for that extension. Do check it out! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes LGTM! Would you also mind updating the snippets too? It was mentioned yesterday someone needed it in the modal form snippet.
@cchaos I've updated every docs that used EuiForm. I don't get you |
@cchaos are there any other examples of EuiForm left out that I forgot to modify |
In the
|
@cchaos Can you please review |
Jenkins, test this |
Preview documentation changes for this PR: https://eui.elastic.co/pr_4734/ |
@cchaos You can merge this. btw where should I submit that vs code extension repo!? |
Summary
Fixed #4711: Updated examples to used EuiForms to use component="form" as a prop
Checklist
Props have proper autodocs and **[playground toggles](https://github.com/elastic/eui/blob/master/wiki/documentation-guidelines.md#adding-playground-toggles)**~Added documentationChecked Code Sandbox works for the any docs examplesAdded or updated jest testsChecked for breaking changes and labeled appropriatelyChecked for accessibility including keyboard-only and screenreader modes